Make ImmutableArray readonly #44640
Merged
Make ImmutableArray readonly #44640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley Issue Details
|
jkotas
reviewed
Nov 13, 2020
| @@ -121,7 +122,7 @@ public static bool Update<T>(ref ImmutableArray<T> location, Func<ImmutableArray | |||
| Requires.NotNull(transformer, nameof(transformer)); | |||
|
|
|||
| bool successful; | |||
| T[]? oldArray = Volatile.Read(ref location.array); | |||
| T[]? oldArray = Volatile.Read(ref Unsafe.As<ImmutableArray<T>, T[]?>(ref location)); | |||
There was a problem hiding this comment.
Can this use just Unsafe.AsRef to just cast-away the readonly-ness? Unsafe.As is too big hammer.
This may be a problem for Roslyn. @jaredpar ? |
It's a headache to update but not a blocker. |
jkotas
approved these changes
Nov 16, 2020
eiriktsarpalis
approved these changes
Nov 17, 2020
|
LGTM. Thank you for your contribution. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #334 .
I noticed that #44629 does not come with api review. I think this can be done similarly.
As an implementation requirement, this PR brings a new reference of S.R.CS.Unsafe to netstandard1.0 target. It this acceptable?