-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to stabilize CopyToAsync_AllDataCopied_Large for Tls13 #44741
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue Details
|
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
Why does this make it better? Seems like it shouldn't matter. |
I'm still digging into it. But here are some (unverified) thoughts. For TLS 1.2 (and less) when handshake is done the streams are really identical and fully interchangeable. With TLS1.3 part of the handshake piggy-backs on first data chunks - that was done to limit round trips and that is reason why we always hit the "RENEGOTIATION" path on Windows. The test sends unidirectional data and and I'm not sure if we have mechanism to send message unless somebody call encrypt data. Now the interesting part: |
Yeah, very weird about the RST. |
I think it may be timing after all @geoffkizer . I opened #44764 to track what I see as underlying problem. |
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamConformanceTests.cs
Show resolved
Hide resolved
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamConformanceTests.cs
Show resolved
Hide resolved
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
test failures are unrelated. |
I'm not 100% what is going on but with this change I did several hundreds runs and I did not see any failure.
The TLS1.3 are not quite symmetric as 1.2.