Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make $(TargetOS) lowercase windows in eng/coredistools.target #44845

Merged
2 commits merged into from
Nov 18, 2020

Conversation

echesakov
Copy link
Contributor

As pointed out in #44490 (comment)

@ViktorHofer @safern PTAL

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Nov 18, 2020

Hello @echesakovMSFT!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 08ee531 into dotnet:master Nov 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
@echesakov echesakov deleted the TargetOS-Lowercase-Windows-CoreDisTools branch April 13, 2021 22:18
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants