Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Browser support for Debugger::Break. #45038

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

lewing
Copy link
Member

@lewing lewing commented Nov 20, 2020

backport of #44305 to release/5.0

/cc @thaystg

Customer Impact

Addresses VS Feedback ticket where using System.Diagnostics.Debugger.Break would cause a runtime assertion rather than a breakpoint. The trivial fix connects the existing functionality to the correct debugger endpoint.

Fixes #44210

Testing

Verified manually and includes a debugger test for basic functionality.

Risk

Very low. Connects existing code.

@lewing lewing added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 20, 2020
@lewing lewing requested a review from thaystg November 20, 2020 23:29
@ghost
Copy link

ghost commented Nov 20, 2020

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

backport of #44305 to release/5.0

/cc @thaystg

Customer Impact

Addresses VS Feedback ticket where using System.Diagnostics.Debug.Debugger.Break would cause a runtime assertion rather than a breakpoint. The trivial fix connects the exiting functionality to the correct debugger endpoint.

Fixes #44210

Testing

Verified manually and includes a debugger test for basic functionality.

Risk

Very low. Connects existing code.

Author: lewing
Assignees: -
Labels:

Servicing-consider, arch-wasm, area-Debugger-mono

Milestone: -

@lewing lewing changed the title Browser support Debugger::Break. [release/5.0] Browser support for Debugger::Break. Nov 21, 2020
@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 21, 2020
@lewing
Copy link
Member Author

lewing commented Nov 21, 2020

Approved in tactics email.

@steveisok steveisok self-requested a review November 21, 2020 00:56
@lewing
Copy link
Member Author

lewing commented Nov 23, 2020

The change is wasm specific the multiple lane failures/timeouts are not related.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants