Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression with tail.callvirt transformation to helper call #45527

Merged
merged 5 commits into from
Dec 10, 2020
Merged

Fix regression with tail.callvirt transformation to helper call #45527

merged 5 commits into from
Dec 10, 2020

Commits on Dec 9, 2020

  1. Add regression test for dotnet#45250

    @echesakov
    echesakov committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    fae5989 View commit details
    Browse the repository at this point in the history

  2. Add VirtCallThisHasSideEffects to more_tailcalls.cs and update more_t… 

    …ailcalls.il
    @echesakov
    echesakov committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    620e49d View commit details
    Browse the repository at this point in the history

  3. Spill "this" if needed to avoid evaluating it twice when "this" is us… 

    …ed to compute the target function pointer in morph.cpp
    @echesakov
    echesakov committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    cfd1a2a View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Update comment in src/coreclr/jit/morph.cpp

    @echesakov
    echesakov committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    4e5b37a View commit details
    Browse the repository at this point in the history

  2. Add TODO-Review in src/coreclr/jit/morph.cpp

    @echesakov
    echesakov committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    abe5378 View commit details
    Browse the repository at this point in the history