[browser][websocket] Fix for Close Description validation

[kjpou1]

The description validation exception was not being percolated through to the unit test

The tests are expecting an exception.

 fail: [FAIL] System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CloseDescriptionIsMaxLengthPlusOne_ThrowsArgumentException(server: ws://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)
  info: Assert.Throws() Failure
  info: Expected: typeof(System.ArgumentException)
  info: Actual:   (No exception was thrown)
  info:    at System.AssertExtensions.Throws[ArgumentException](String expectedParamName, Action action)
  info:    at System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CloseDescriptionIsMaxLengthPlusOne_ThrowsArgumentException(Uri server)
  info: --- End of stack trace from previous location ---

Running the outerloop tests locally passes correctly with this modification which follows the ManagedWebSocket.cs verification sequence.

See #45470 for tests

Fix #45531

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The description validation exception was not being percolated through to the unit test

The tests are expecting an exception.

 fail: [FAIL] System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CloseDescriptionIsMaxLengthPlusOne_ThrowsArgumentException(server: ws://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)
  info: Assert.Throws() Failure
  info: Expected: typeof(System.ArgumentException)
  info: Actual:   (No exception was thrown)
  info:    at System.AssertExtensions.Throws[ArgumentException](String expectedParamName, Action action)
  info:    at System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CloseDescriptionIsMaxLengthPlusOne_ThrowsArgumentException(Uri server)
  info: --- End of stack trace from previous location ---

Running the outerloop tests locally passes correctly with this modification.

See #45470 for tests

Fix #45531

Author:	kjpou1
Assignees:	-
Labels:	area-System.Net
Milestone:	-

[radical]

Just trying to understand the situation with tests here.

• Do all the enabled tests pass for websockets?
  • If so, then are there some disabled tests that this would be fixing?
    • If so, then can we enable those tests with this PR?

I'm just wondering if there are any tests that we'll be able to see, going from FAIL to PASS.

In the PR that you linked, I see some tests being marked with ActiveIssue for 45531, which I guess will be removed after this is merged.

[kjpou1]

The ActiveIssue for 45531 will be removed

[kjpou1]

Can we get another review?

[kjpou1]

Build iOS x64 Release AllSubsets_Mono failing in all CI jobs #45654

[kjpou1]

The failure for Build iOS x64 Release AllSubsets_Mono failing in all CI jobs is unrelated see issue: #45468

/cc @marek-safar @stephentoub @lewing