Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BinderEventListener not listen to TplEventSource #45570

Merged
2 commits merged into from
Dec 4, 2020
Merged

Make BinderEventListener not listen to TplEventSource #45570

2 commits merged into from
Dec 4, 2020

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Dec 3, 2020 •
edited by hoyosjs
Loading

Fix #37132.
Fix #45088

Note: there is an actual product issue here that is related to a deadlock that can occur from using EventListeners to listen to TplEventSource. I will file a separate issue to track the EventListener deadlock bug.

In the meantime, this changes BinderEventListener to not listen for TplEventSource which shouldn't be necessary for these tests (the EventListener doesn't check any payload from TplEventSource).

@ghost
Copy link

ghost commented Dec 3, 2020

Tagging subscribers to this area: @vitek-karas, @agocke, @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #37132.

Note: there is an actual product issue here that is related to a deadlock that can occur from using EventListeners to listen to TplEventSource. I will file a separate issue to track the EventListener deadlock bug.

In the meantime, this changes BinderEventListener to not listen for TplEventSource which shouldn't be necessary for these tests (the EventListener doesn't check any payload from TplEventSource).

Author: sywhang
Assignees: -
Labels:

area-AssemblyLoader-coreclr
Milestone: -

@sywhang
Copy link
Contributor Author

sywhang commented Dec 3, 2020

#45571 tracks the EventListener bug.

@hoyosjs
Copy link
Member

hoyosjs commented Dec 3, 2020 •
edited
Loading

As long as it's not needed - which @elinor-fung would know better - LGTM. I don't expect any async/task/parallel info to be needed for loading/binding.

@sywhang sywhang requested a review from vitek-karas December 3, 2020 23:53
elinor-fung
elinor-fung approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be needed. When the tests were first added, the listener enabled the TPL event source as a (roundabout) way to enable the managed ActivityTracker, but that has since been handled by the assembly loader tracing.

Thanks @sywhang and @hoyosjs!

src/tests/Loader/binding/tracing/BinderEventListener.cs Show resolved Hide resolved
@ghost
Copy link

ghost commented Dec 4, 2020

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit f81e708 into dotnet:master Dec 4, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elinor-fung elinor-fung elinor-fung approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

@vitek-karas vitek-karas Awaiting requested review from vitek-karas

Assignees
No one assigned
Labels
area-AssemblyLoader-coreclr
Projects
None yet
Milestone
No milestone
4 participants
@sywhang @hoyosjs @elinor-fung @Dotnet-GitSync-Bot