-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/5.0] Add Microsoft StrongNameKey back to System.Composition* #45757
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @ViktorHofer Issue DetailsBackport of #45756 to release/5.0 /cc @ViktorHofer Customer ImpactThe changed public key token in the 5.0 package causes the CLR to not bind references even with binding redirects. TestingThe package was produced locally and the Microsoft public key token is again used for any live built assets in the package. RiskLow. The package is already broken for at least customers on .NET Framework. The change only involves swapping out the public key token.
|
release/5.0 builds failing on OSX:
This probably started to happen in the last days as another 5.0 build 5 days ago succeeded. cc @dotnet/runtime-infrastructure |
cc @danmosemsft or @ericstj for tactics (I can talk about this change as well - don't have a preference) |
This needs to include the packages in the build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module @ericstj's comment that we need to include the packages to the build
The OSX issue will be fixed by: #45809 |
After #45799 is in, I will update the PR to build the package. |
Yes we discussed this. It's not strictly necessary. Since the strong name is changing, that's sufficient to ensure there's no clash in GAC / load on .NETFramework. |
Backport of #45756 to release/5.0
Fixes #45638
/cc @ViktorHofer
Customer Impact
The changed public key token in the 5.0 package causes the CLR to not bind references even with binding redirects.
Testing
The package was produced locally and the Microsoft public key token is again used for any live built assets in the package.
Risk
Low. The package is already broken for at least customers on .NET Framework. The change only involves swapping out the public key token.