Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Add Microsoft StrongNameKey back to System.Composition* #45757

Merged
merged 4 commits into from
Dec 11, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 8, 2020

Backport of #45756 to release/5.0
Fixes #45638

/cc @ViktorHofer

Customer Impact

The changed public key token in the 5.0 package causes the CLR to not bind references even with binding redirects.

Testing

The package was produced locally and the Microsoft public key token is again used for any live built assets in the package.

Risk

Low. The package is already broken for at least customers on .NET Framework. The change only involves swapping out the public key token.

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer ViktorHofer added Servicing-consider Issue for next servicing release review area-System.Composition labels Dec 8, 2020
@ghost
Copy link

ghost commented Dec 8, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #45756 to release/5.0

/cc @ViktorHofer

Customer Impact

The changed public key token in the 5.0 package causes the CLR to not bind references even with binding redirects.

Testing

The package was produced locally and the Microsoft public key token is again used for any live built assets in the package.

Risk

Low. The package is already broken for at least customers on .NET Framework. The change only involves swapping out the public key token.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-System.Composition

Milestone: -

@ViktorHofer
Copy link
Member

release/5.0 builds failing on OSX:

Error: Not a directory @ dir_s_rmdir - /usr/local/Cellar/openssl 
Removing: /Users/runner/Library/Caches/Homebrew/openldap--2.4.55.mojave.bottle.tar.gz... (2.8MB) 
Removing: /usr/local/Cellar/openssl/1.0.2t... (1,787 files, 12.0MB) 
Installing automake has failed!

This probably started to happen in the last days as another 5.0 build 5 days ago succeeded. cc @dotnet/runtime-infrastructure

@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 8, 2020

cc @danmosemsft or @ericstj for tactics (I can talk about this change as well - don't have a preference)

@ericstj
Copy link
Member

ericstj commented Dec 8, 2020

This needs to include the packages in the build.

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 8, 2020
@leecow leecow modified the milestones: 5.0.x, 5.0.2 Dec 8, 2020
@ViktorHofer
Copy link
Member

@Anipik 5.0 builds are failing. We should fix that.

@Anipik one more thing. Can you please let me know which changes in the infra are required to ship the System.Composition packages?

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module @ericstj's comment that we need to include the packages to the build

@safern
Copy link
Member

safern commented Dec 9, 2020

The OSX issue will be fixed by: #45809

@ViktorHofer
Copy link
Member

After #45799 is in, I will update the PR to build the package.

@Anipik Anipik merged commit 7728efe into release/5.0 Dec 11, 2020
@Anipik Anipik deleted the backport/pr-45756-to-release/5.0 branch December 11, 2020 20:36
@ViktorHofer
Copy link
Member

@Anipik thanks for merging. Did you ask @ericstj if the change of the strong name key requires the assembly version to be bumped?

@ericstj
Copy link
Member

ericstj commented Dec 14, 2020

Yes we discussed this. It's not strictly necessary. Since the strong name is changing, that's sufficient to ensure there's no clash in GAC / load on .NETFramework.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants