Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Update ServiceModel version on compat pack #45905

Merged
merged 4 commits into from
Dec 11, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 10, 2020

Backport of #45904 to release/5.0

Fixes: #43837

/cc @safern

Customer Impact

If the compat pack is referenced they would get an older version of WCF packages.

Testing

Manual and visual testing. I verified that the dependency is updated correctly and that the package restores correctly in multiple tfms.

Risk

Low

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern safern requested a review from ericstj December 10, 2020 20:00
@safern
Copy link
Member

safern commented Dec 10, 2020

I'll add the package to the package list that needs to be built once the branch resets the package list.

cc: @Anipik

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 11, 2020
@ericstj
Copy link
Member

ericstj commented Dec 11, 2020

@Anipik can you merge this when ready and ensure we build the package?

@safern
Copy link
Member

safern commented Dec 11, 2020

I doubled checked the package was well formed and realized that all the dependencies for packages that we build in dotnet/runtime were 5.0.2, which is wrong as we don't ship all packages. So that's why I needed to update more than just libraries-packages on the last commit. Now the package looks and restores fine.

@@ -36,7 +38,9 @@
<PrereleaseLibraryPackage Include="System.Runtime.Caching" />
<PrereleaseLibraryPackage Include="System.Security.AccessControl" />
<PrereleaseLibraryPackage Include="System.Security.Cryptography.Cng" />
<PrereleaseLibraryPackage Include="System.Security.Cryptography.Pkcs" />
<PrereleaseLibraryPackage Include="System.Security.Cryptography.Pkcs">
<Version>5.0.1</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anipik this is a case where I think our simpler baselining model could help. We could leave everything at RTM here, and just record the servicing versions of packages as their new baseline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, exactly. The problem with the Compat pack is that it relies on package-index data as it uses IndexedDependency item.

@safern safern merged commit 4a61651 into release/5.0 Dec 11, 2020
@safern safern deleted the backport/pr-45904-to-release/5.0 branch December 11, 2020 23:47
@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2021
@danmoseley danmoseley added this to the 5.0.2 milestone Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants