-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/5.0] Update ServiceModel version on compat pack #45905
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
I'll add the package to the package list that needs to be built once the branch resets the package list. cc: @Anipik |
@Anipik can you merge this when ready and ensure we build the package? |
…904-to-release/5.0
…sions are correct
I doubled checked the package was well formed and realized that all the dependencies for packages that we build in dotnet/runtime were |
@@ -36,7 +38,9 @@ | |||
<PrereleaseLibraryPackage Include="System.Runtime.Caching" /> | |||
<PrereleaseLibraryPackage Include="System.Security.AccessControl" /> | |||
<PrereleaseLibraryPackage Include="System.Security.Cryptography.Cng" /> | |||
<PrereleaseLibraryPackage Include="System.Security.Cryptography.Pkcs" /> | |||
<PrereleaseLibraryPackage Include="System.Security.Cryptography.Pkcs"> | |||
<Version>5.0.1</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anipik this is a case where I think our simpler baselining model could help. We could leave everything at RTM here, and just record the servicing versions of packages as their new baseline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, exactly. The problem with the Compat pack is that it relies on package-index
data as it uses IndexedDependency
item.
Backport of #45904 to release/5.0
Fixes: #43837
/cc @safern
Customer Impact
If the compat pack is referenced they would get an older version of WCF packages.
Testing
Manual and visual testing. I verified that the dependency is updated correctly and that the package restores correctly in multiple tfms.
Risk
Low