Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process.Start() failure should include path #46417

Merged
merged 19 commits into from
Jul 14, 2021
Merged

Process.Start() failure should include path #46417

merged 19 commits into from
Jul 14, 2021

Commits on Mar 27, 2021

  1. Adding ProcessStartException

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    a98caf7 View commit details
    Browse the repository at this point in the history

  2. Reverting ProcessStartException

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    b07d1a2 View commit details
    Browse the repository at this point in the history

  3. First version

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    c10f235 View commit details
    Browse the repository at this point in the history

  4. Fixing merge issue

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    08ee21a View commit details
    Browse the repository at this point in the history

  5. Using interop call instead of intermediate exception to get error msg

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    5fb88c3 View commit details
    Browse the repository at this point in the history

  6. Fixing typo

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    e8a7cf8 View commit details
    Browse the repository at this point in the history

  7. Change checks for exception message

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    7e58fad View commit details
    Browse the repository at this point in the history

  8. Update src/libraries/System.Diagnostics.Process/src/System/Diagnostic… 

    …s/Process.cs

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
    @batzen @adamsitnik
    batzen and adamsitnik committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    68ccd75 View commit details
    Browse the repository at this point in the history

  9. Update src/libraries/System.Diagnostics.Process/src/System/Diagnostic… 

    …s/Process.Unix.cs

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
    @batzen @adamsitnik
    batzen and adamsitnik committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    7384df6 View commit details
    Browse the repository at this point in the history

  10. Using common method to create exception and updating error message

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    81b963e View commit details
    Browse the repository at this point in the history

  11. Fixing merge mistake

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    24d4232 View commit details
    Browse the repository at this point in the history

  12. Using AssertExtensions.ThrowsContains

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    40f8c7a View commit details
    Browse the repository at this point in the history

  13. Fixing code for unix

    @batzen
    batzen committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    29a22ef View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Merge branch 'main' into issues/39928

    @jeffhandley
    jeffhandley committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    f72a1f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Merge branch 'main' into issues/39928

    @jeffhandley
    jeffhandley committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    ba64c57 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Address PR feedback

    @jeffhandley
    jeffhandley committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    c885672 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jeffhandley/39928

    @jeffhandley
    jeffhandley committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    0b91e4e View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @jeffhandley @stephentoub
    jeffhandley and stephentoub authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    09dc7e7 View commit details
    Browse the repository at this point in the history

  4. Fix ErrorInfo type reference

    @jeffhandley
    jeffhandley committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    e6c160a View commit details
    Browse the repository at this point in the history