Improve OidLookup.ToOid perf, in particular for X509Certificate2.Extensions #46819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`X509Certificate2.Extensions` invokes `CertificatePal.Extensions`, which in turn creates the extensions collection, invoking `new Oid(string)` for each. This in turn calls `OidLookup.ToOid` in order to gather the friendly name, even though in many situations, no one actually cares about the friendly name. We can instead call `new Oid(string, null)`, which makes the friendly name lazily initialized on first use, saving the `OidLookup.ToOid` call when it's not needed, and significantly reducing the time to call Extensions (in particular when the predefined OID lookup tables don't contain the OID for an extension and when it can't be found on lookup).
ToOid has a cache, but it only caches successful results. If ToOid fails to find the relevant OID, nothing is cached, which makes the failure path very expensive, as every ToOid call for that OID takes the slow path. This lets it be cached.
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq Issue DetailsSee commit descriptions. This halves the time it takes to execute cc: @bartonjs, @brianrob, @DamianEdwards Contributes to #44598
|
bartonjs
approved these changes
Jan 11, 2021
Closed
36 tasks
ghost
locked as resolved and limited conversation to collaborators
stephentoub
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions.
This halves the time it takes to execute
CertificateManager.Instance.EnsureAspNetCoreHttpsDevelopmentCertificate(https://github.com/dotnet/aspnetcore/blob/b3aa128ae4d124701f7bb2c636f20c057eb3aa46/src/Shared/CertificateGeneration/CertificateManager.cs#L166) when there's already a certificate installed.cc: @bartonjs, @brianrob, @DamianEdwards
Contributes to #44598