Remove DeviceContext HWND handling #47081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeviceContext
has a bunch of overhead - allocations, interop calls etc.However, in the case of
Graphics.CopyFromScreen
, which is the only user of theHWND
features inDeviceContext
, we can avoid all of that and remove a bunch of code fromDeviceContext
.Just call
IntPtr screenDC = GetDC(IntPtr.Zero)
andReleaseDC(screenDC)
/cc @JeremyKuhne