Fixed compilation for libicu 68. #47352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tarekgh, @safern, @krwq Issue Detailslibicu 68 deprecated its defines for Fixes #47346
|
|
Looks need to do more here as I am seeing a lot of failures like the following one. CC @jkotas |
|
|
ManickaP
force-pushed
the
mapichov/47346_stdbool
branch
from
4549cfc
to
735028d
Compare
jkotas
reviewed
Jan 23, 2021
src/libraries/Native/Unix/System.Globalization.Native/pal_normalization.c
Outdated
Show resolved
Hide resolved
|
Failing tests are #47374 |
jkotas
approved these changes
Jan 23, 2021
|
Thank you! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libicu 68 deprecated its defines for
TRUE/FALSE. This makes use of standard<stdbool.h>constants.The change only lower-cases the constant names, we were already including the header file.
Fixes #47346