Support Async DNS lookup on older Windows from impersonificated context #47435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is follow-up on #45816. It seems like older windows (Win8 and Server 2012) fail with different error. As @stephentoub pointed me the right direction, this change also adds tests missing in original change. contributes to #29935
|
|
LINQ/float test failures are #47374 |
stephentoub
approved these changes
Jan 26, 2021
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/519074680 |
|
@wfurt backporting to release/5.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: test WindowsIdentityImpersonatedTests runs
error: sha1 information is lacking or useless (src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test WindowsIdentityImpersonatedTests runs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
wfurt
added a commit
to wfurt/runtime
that referenced
this pull request
Jan 29, 2021
…xt (dotnet#47435) * test WindowsIdentityImpersonatedTests runs * fix win8 * add test variant * final cleanup
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up on #45816. It seems like older windows (Win8 and Server 2012) fail with different error. As @stephentoub pointed me the right direction, this change also adds tests missing in original change.
contributes to #29935
fixes #45165