-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Async DNS lookup on older Windows from impersonificated context #47435
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is follow-up on #45816. It seems like older windows (Win8 and Server 2012) fail with different error. As @stephentoub pointed me the right direction, this change also adds tests missing in original change. contributes to #29935
|
LINQ/float test failures are #47374 |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/backport to release/5.0 |
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/519074680 |
@wfurt backporting to release/5.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: test WindowsIdentityImpersonatedTests runs
error: sha1 information is lacking or useless (src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test WindowsIdentityImpersonatedTests runs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
…xt (dotnet#47435) * test WindowsIdentityImpersonatedTests runs * fix win8 * add test variant * final cleanup
This is follow-up on #45816. It seems like older windows (Win8 and Server 2012) fail with different error. As @stephentoub pointed me the right direction, this change also adds tests missing in original change.
contributes to #29935
fixes #45165