JIT: run instrumentation phase just after importing #47476
Conversation
As a prerequisite to enabling efficient instrumentation, add instrumentation immediately after importing, so the flow graph more closely reflects the IL level view.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Contributes to #46882. PTAL @dotnet/jit-contrib |
|
/azp run runtime-jit-experimental |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Jit experimental has some known failures in OSR & EH Write Through -- mainly looking at the PGO testing it does here. |
|
It seems odd to push more things to before the inlining-only and import-only bail-outs. Shouldn't we push more things after those? I guess I don't understand what requires us to do something to inlinees here, versus after then are imported to the inliner. |
Not sure I understand what you're asking. We want to instrument early since instrumentation is keyed to IL and the presence of blocks with no IL relationship can confuse things. Currently we can just skip such blocks but when we start looking at spanning tree based instrumentation those blocks can potentially alter the in-tree and non-tree edge sets and it's easier not to have to worry about that at all. We currently only instrument root methods, but at some point in the future we may instrument inlinees. I suspect import-only is largely a dead code path now ... ? Though I think @erozenfeld may have used it in his call graph construction prototype. At any rate nothing happens here without BBINSTR being set. |
That's correct, I used import-only mode in the call graph prototype. |
There was a problem hiding this comment.
I chatted with @AndyAyersMS and cleared up my questions.
LGTM.
|
Jit experimental test failures are as expected (all pgo tests passed). |
ghost
locked as resolved and limited conversation to collaborators
As a prerequisite to enabling efficient instrumentation, add instrumentation
immediately after importing, so the flow graph more closely reflects the IL
level view.