Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup for Rfc2898DeriveBytes #47483

Merged
merged 5 commits into from
Jan 27, 2021
Merged

Minor cleanup for Rfc2898DeriveBytes #47483

merged 5 commits into from
Jan 27, 2021

Commits on Jan 26, 2021

  1. Remove password member for Rfc2898DeriveBytes. 

    The _password field is not needed since CryptDeriveKey was not ported
from the Desktop framework.

Removing the field also allows removing a defensive copy and clearing it
during disposal.
    @vcsjones
    vcsjones committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    3b00adf View commit details
    Browse the repository at this point in the history

  2. Add a test

    @vcsjones
    vcsjones committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    5649f61 View commit details
    Browse the repository at this point in the history

  3. Zero password bytes after use

    @vcsjones
    vcsjones committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    b24fabb View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Clear text password bytes for provided salt and random salt.

    @vcsjones
    vcsjones committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    00e8674 View commit details
    Browse the repository at this point in the history

  2. Fix extra blank line

    @vcsjones
    vcsjones committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    406e478 View commit details
    Browse the repository at this point in the history