Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to dotnet/runtime version 6.0.0-preview.2.21076.5 #47489

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jan 26, 2021

Build ID 20210126.5

Fixes #42250 cc @jkotas

Before this:

sn -vf c:\src\dotnet\runtime\artifacts\bin\System.Runtime.CompilerServices.Unsafe\net6.0-Debug\System.Runtime.CompilerServices.Unsafe.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

c:\src\dotnet\runtime\artifacts\bin\System.Runtime.CompilerServices.Unsafe\net6.0-Debug\System.Runtime.CompilerServices.Unsafe.dll is a delay-signed or test-signed assembly

After:

sn -vf c:\src\dotnet\runtime\artifacts\bin\System.Runtime.CompilerServices.Unsafe\net6.0-Debug\System.Runtime.CompilerServices.Unsafe.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Failed to verify assembly -- Strong name validation failed.

Which is a good thing, SN doesn't know about public sign, but is observing that the assembly says it should be signed (rather than delay signed) and the signature is bogus, which is what public sign does.

@ghost
Copy link

ghost commented Jan 26, 2021

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Build ID 20210126.5

Fixes #42250 cc @jkotas

Before this:

sn -vf c:\src\dotnet\runtime\artifacts\bin\System.Runtime.CompilerServices.Unsafe\net6.0-Debug\System.Runtime.CompilerServices.Unsafe.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

c:\src\dotnet\runtime\artifacts\bin\System.Runtime.CompilerServices.Unsafe\net6.0-Debug\System.Runtime.CompilerServices.Unsafe.dll is a delay-signed or test-signed assembly

After:

sn -vf c:\src\dotnet\runtime\artifacts\bin\System.Runtime.CompilerServices.Unsafe\net6.0-Debug\System.Runtime.CompilerServices.Unsafe.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Failed to verify assembly -- Strong name validation failed.

Which is a good thing, SN doesn't know about public sign.

Author: ericstj
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost
Copy link

ghost commented Jan 26, 2021

Hello @ViktorHofer!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ericstj
Copy link
Member Author

ericstj commented Jan 26, 2021

Failing tests are #47374

@ericstj ericstj merged commit 23f1ede into dotnet:master Jan 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local test run fails for target net461 with FileLoadException S.R.CS.Unsafe
4 participants