Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ClosedDuringOperation_Throws_ObjectDisposedExceptionOrSocketException #47571

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jan 28, 2021

Disable tests to unblock CI. Tracked in #47561

@ghost
Copy link

ghost commented Jan 28, 2021

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jan 28, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Disable tests to unblock CI. Tracked in #47561

Author: hoyosjs
Assignees: -
Labels:

area-System.Net.Sockets, auto-merge

Milestone: -

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test has multiple cases because of subclassing, and only ones with a certain trait are failing (ones dealing with sync overloads).

Instead of disabling all of them by decorating the method with [ActiveIssue], I'd prefer to add the following code to the very beginning of the two test:

// [ActiveIssue("https://github.com/dotnet/runtime/issues/47561")]
if (UsesSync) return;

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm fine merging it as-is to unblock clean CI. If we do so, I will file a more sophisticated PR soon.

@hoyosjs hoyosjs merged commit d8be798 into dotnet:master Jan 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@hoyosjs hoyosjs deleted the juhoyosa/disable-ReceiveFrom-Socket branch June 29, 2021 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants