Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix armel build #47771

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Fix armel build #47771

merged 1 commit into from
Feb 5, 2021

Conversation

gbalykov
Copy link
Member

@gbalykov gbalykov commented Feb 2, 2021

Build for armel fails after #47502 with:

/home/runtime/src/coreclr/tools/aot/crossgen2/crossgen2.csproj(114,5): error MSB3030: Could not copy the file "/home/runtime/artifacts/bin/coreclr/Linux.armel.Release/x64/libclrjit_unix_armel_x64.so" because it was not found.

This change is a cleanup for armel, since there was some inconsistency.

Before:

ARCH_HOST_NAME=armel
ARCH_TARGET_NAME=arm

After:

ARCH_HOST_NAME=armel
ARCH_TARGET_NAME=armel

cc @alpencolt

@gbalykov
Copy link
Member Author

gbalykov commented Feb 4, 2021

cc @jkotas

@jkotas
Copy link
Member

jkotas commented Feb 4, 2021

Looks like a follow up on #41126 . @davidwrighton Could you please take a look?

Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good

@davidwrighton davidwrighton merged commit 9a283e1 into dotnet:master Feb 5, 2021
@gbalykov
Copy link
Member Author

gbalykov commented Feb 5, 2021

Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants