Add hostfxr_get_dotnet_environment_info API #48097
Conversation
|
Tagging subscribers to this area: @vitek-karas, @agocke Issue DetailsThis PR adds a new hostfxr API to retrieve the installed SDKs and frameworks,
|
src/installer/tests/Assets/TestProjects/HostApiInvokerApp/HostFXR.cs
Outdated
Show resolved
Hide resolved
src/installer/tests/Assets/TestProjects/HostApiInvokerApp/HostFXR.cs
Outdated
Show resolved
Hide resolved
src/installer/tests/Assets/TestProjects/HostApiInvokerApp/HostFXR.cs
Outdated
Show resolved
Hide resolved
Export fn
Validate size of structs Test that result_context isn't modified
|
What's the current status of the mitigation logic discussed in #46128 and dotnet/sdk#15021? Is that supposed to be part of this API? |
This PR does not address the mitigation logic mentioned in the linked spec, it just adds an API that mimics the behavior of |
Update tests
|
I created #48180 to track that change (since it should apply to all of the enumeration APIs as well as actual framework resolution). |
| int env_sdk_info_size = (sdks.Count > 0) ? Marshal.SizeOf(sdks[0]) : -1; | ||
| if (env_sdk_info_size != -1 && (env_sdk_info_size != sdks[0].size)) | ||
| throw new Exception($"Size field value of hostfxr_dotnet_environment_sdk_info struct is {sdks[0].size} but {env_sdk_info_size} was expected."); |
There was a problem hiding this comment.
Nit: why not validate this when we add the SDK/framework to their respective lists? Each has this field, so it would make sense to validate all of them.
ghost
locked as resolved and limited conversation to collaborators
This PR adds a new hostfxr API to retrieve the installed SDKs and frameworks,
hostfxr_get_dotnet_environment_info. See #46128 for the design of the API.