improve certificate change detection on linked stores #48151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis change checks if rootDirectory using link can point to another link and so on. I was on the fence if I should wrap the lookup in reasonable amount of iterations. I'm not sure about the names.
|
bartonjs
reviewed
Feb 11, 2021
...ryptography.X509Certificates/src/Internal/Cryptography/Pal.Unix/CachedSystemStoreProvider.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
jeffhandley
force-pushed
the
certReadlink
branch
from
0a6a117 to
8fcea98
Compare
bartonjs
approved these changes
Mar 25, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change checks if rootDirectory using
readlink. Seems like the links become more popular and this will allow to monitor the link it self as well as the directory it links to.link can point to another link and so on. I was on the fence if I should wrap the lookup in reasonable amount of iterations.
I decided not to for simplicity so this covers default configuration.
I'm not sure about the names.