Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: workaround for unreliable change detection in fgReorderBlocks #48516

Merged
merged 2 commits into from
Feb 20, 2021
Merged

JIT: workaround for unreliable change detection in fgReorderBlocks #48516

merged 2 commits into from
Feb 20, 2021

Commits on Feb 19, 2021

  1. JIT: workaround for unreliable change detection in fgReorderBlocks 

    This method costs trees, which can in turn modify the IR by swapping operands.
As a result the bool value returned doesn't properly reflect whether any
changes happened.

This impacts proper reporting phase status by `optOptimizeLayout'. Since phase
status just gates post-phase dumps and checks, we'll just claim this phase
always modifies IR.

Fixes dotnet#48495.
    @AndyAyersMS
    AndyAyersMS committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    7007556 View commit details
    Browse the repository at this point in the history

  2. Similar workaround for optInvertLoops.

    @AndyAyersMS
    AndyAyersMS committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    0d26de1 View commit details
    Browse the repository at this point in the history