-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix high frag in gen2 #48601
Closed
Closed
Fix high frag in gen2 #48601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n when gen 2 fragmentation becomes too high. Details: - New config setting GCConserveMemory with values between 0 and 9 - intuitively, the higher the value, the more GC tries to keep gen 2 compact. - Implementation: the config value is considered in dt_high_frag_p as the desired percentage*10 of useful data in gen 2. In other words, 100 - config value*10 is the fragmentation threshold above which a blocking gen 2 is performed.
This was referenced Mar 11, 2021
…o make the compaction decision. Also, only do the computations only for gen 1 GCs to cut down on the back-to-back gen 2 GCs that we were observing.
This was referenced Mar 22, 2021
…mbined fragmentation in gen 2 + loh, rather than just the fragmentation in loh.
…ACE_GC and removed debugging code.
PeterSolMS
added a commit
to PeterSolMS/runtime-1
that referenced
this pull request
Aug 3, 2021
PeterSolMS
added a commit
that referenced
this pull request
Aug 31, 2021
ghost
locked as resolved and limited conversation to collaborators
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Initial perf data suggest this does have the desired effect of trimming down average gen 2 size (and especially trimming it down when the survivorship in gen 2 goes down). There was also the expected effect of larger GC pause times, and an unexpected effect of larger LOH sizes, probably because we also trigger fewer gen 2 collections.