[mono][mbr] Implement DOTNET_MODIFIABLE_ASSEMBLIES support #49507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
requested review from
BrzVlad,
CoffeeFlux,
marek-safar,
SamMonoRT,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsImplements #47274 for Mono.
Depends on #49505 for the DebuggableAttribute parsing /cc @vargaz @BrzVlad @mikem8361
|
BrzVlad
approved these changes
Mar 12, 2021
vargaz
approved these changes
Mar 12, 2021
If it's set to "debug" (case insensitive) then hot reload is enabled for assemblies compiled in debug mode. Otherwise hot reload is disabled
with the optimizer disabled flag
On a per-assembly basis
lambdageek
force-pushed
the
mbr-modifiable-assemblies
branch
from
79fb228 to
458edc0
Compare
51 tasks
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #47274 for Mono.
DOTNET_MODIFIABLE_ASSEMBLIESenvirnonment variable must be set todebugfor hot reload to be enabled (in addition to the interpreter being enabled)DebuggableAttributefor theDisableOptimizationsbit. If an assembly doesn't have the bit set, it can't be reloaded./cc @vargaz @BrzVlad @mikem8361