-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove repetitions ';' #50236
remove repetitions ';' #50236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM. There's a related stylecop rule we should look at subsequently enabling.
@stephentoub I think now is the time. Where can I enable it? |
You'd change the "None" in this line to be "Warning": runtime/eng/CodeAnalysis.ruleset Line 289 in 400311b
I've not tried and don't know what else it might flag. Feel free to try. |
Turns out we can't enable SA1106. I just tried it, and it's flagging empty-body loops (which we allow) as empty statements (e.g. |
cc @sharwell |
Yes, this is unlikely to change for StyleCop Analyzers. However, the relaxed form of the rule you want seems reasonably likely to get accept as part of the code style package in Roslyn so maybe we implement it there? |
@sharwell, sounds good to me. |
Cleanup code