Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ILLink warnings in System.Diagnostics.DiagnosticSource #50265

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Resolve ILLink warnings in System.Diagnostics.DiagnosticSource #50265

merged 3 commits into from
Apr 7, 2021

Commits on Mar 25, 2021

  1. Resolve ILLink warnings in System.Diagnostics.DiagnosticSource (Round 1) 

    Contributes to dotnet#45623
    @eerhardt
    eerhardt committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    47ce518 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Update based on the following plan: 

    1. Mark DiagnosticSource.Write(string,object) as RequiresUnreferencedCode
2. Suppress the warnings for any .NET libraries that call the DiagnosticSource.Write() API, and annotate the .NET types being passed in to preserve their important properties.
    - This was done for HttpClient. ASP.NET and EF will need separate changes when those assemblies are made trim compatible
3. Annotate Activity and its small closure of types (ActivityLink, ActivityEvent, ActivityContext, etc) to ensure none of those properties are trimmed.
4. Suppress trim warnings inside DiagnosticSourceEventSource since the public Write method is marked with RequiresUnreferencedCode.
    @eerhardt
    eerhardt committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    d6ef851 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Update ref assembly with new attributes.

    @eerhardt
    eerhardt committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    f632025 View commit details
    Browse the repository at this point in the history