-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage of process_vm_readv in createdump #50477
Conversation
Tagging subscribers to this area: @tommcdon Issue DetailsThis PR tries to use Fixes dotnet/diagnostics#2098 in main.
|
fyi @shirhatti |
Hello @hoyosjs! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Thanks for the fix. Can we expect this to be backported to 5.0? |
@saul I've opened the backport PR. Will give the change some bake time against the tests and ask ship room for permission to add to servicing in 5.0. |
This PR tries to use
process_vm_readv
and falls back to usingpread
on/proc/mem
if the first fails withEPERM
. This is needed as docker 19.03 on kernels newer than 4.8 allows to useptrace
as long as yama settings don't restrict it, but it does not allow usage ofprocess_vm_*
syscalls. These were added very recently to the allow-list but we need a mechanism to allow customers to collect dumps in their containerized environments.Fixes dotnet/diagnostics#2098 in main.