[mono] More domain cleanups #50479
Merged
[mono] More domain cleanups #50479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
CoffeeFlux,
lambdageek,
SamMonoRT and
thaystg
as code owners
|
Tagging subscribers to this area: @CoffeeFlux Issue Details
|
vargaz
force-pushed
the
domain-cleanup3
branch
2 times, most recently
from
ceab8bb to
1905405
Compare
This was referenced Apr 1, 2021
|
@vargaz could you resolve the confict @CoffeeFlux @lambdageek plase review |
…d-context.c. Add a mono_alc_get_all_loaded_assemblies () helper function to return a array of all the loaded assemblies. Use this instead of accessing domain->loaded_assemblies directly.
Move functions from appdomain.c to more assembly-load-context.c/ extern-only.c.
CoffeeFlux
approved these changes
Apr 5, 2021
There was a problem hiding this comment.
LGTM, thanks!
There might end up being conflicts with #49637 but they should be easy to resolve on either end.
| mono_appdomains_lock (); | ||
| domain_id_alloc (domain); | ||
| mono_appdomains_unlock (); | ||
| // FIXME: why is this needed ? |
There was a problem hiding this comment.
Did removing this cause problems? I don't see it referenced anywhere else now, and the GC shouldn't(?) be using it to find roots, so I think this can just go away.
There was a problem hiding this comment.
Will try to remove later.
| } | ||
|
|
||
| mono_assembly_addref (ass); | ||
| // Prepending here will break the test suite with frequent InvalidCastExceptions, so we have to append |
There was a problem hiding this comment.
The fact prepending here doesn't work still annoys me. I wish I'd left more info about why, since it's not obvious months later what the actual problem was.
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Apr 6, 2021
…shim_mono # By Aaron Robinson (10) and others # Via GitHub * upstream/main: (108 commits) [mbr] Add Apple sample (dotnet#50740) make EstablishProxyTunnelAsync throw on failure status code from proxy (dotnet#50763) Improve RGB Min Max evaluation performance by using 2 or 3 comparison… (dotnet#50622) [mono] More domain cleanups (dotnet#50479) Fix Crossgen2 of PlatformDefaultMemberFunction methods and calls. (dotnet#50754) Disable EventSource generator in design-time builds (dotnet#50741) Fix X509 test failures on Android (dotnet#50301) Do not confuse fgDispBasicBlocks in fgMorphBlocks (dotnet#50703) Enforce 64KB event payload size limit on EventPipe (dotnet#50600) Reorganize CoreCLR native build to reduce CMake reconfigures when the build system is untouched (dotnet#49906) [mbr] Turn on hot reload for iOS, tvOS and MacCatalyst (dotnet#50458) improve connection scavenge logic by doing zero-byte read (dotnet#50545) Resolve call mdtokens when making tier 1 inline observations (dotnet#50675) Annotate APIs in System.Private.Xml (dotnet#49682) Support compiling against OpenSSL 3 headers Change Configuration.Json to use a regular Dictionary. (dotnet#50611) Remove unused BigNumFromBinary P/Invoke (dotnet#50670) Make Ninja the default CMake generator on Windows for the repo (dotnet#49715) [AppleAppBuilder] Entitlements to run tests on catalyst using the JIT (dotnet#50637) [mono] Fix delegate invokes to dynamic methods in mixed mode. (dotnet#50547) ... # Conflicts: # src/mono/dlls/mscordbi/CMakeLists.txt
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.