[mbr] Add support for editing property getters/setters #51011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that modifications of getter or setter bodies add new rows to the MethodSemantics table that point to an existing method def (with an updated IL) and to an existing row in the property table. So there is nothing to do.
…ng methods. We only support modifications of getters/setters, not adding a new getter or setter where there wasn't one previously. (Adding new methods in general fails right now)
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsA getter/setter change comes in as a modification of the Property table and as several new rows in MethodSemantics. So in pass1 just verify that MethodSemantics only has getter/setter rows and that they point at existing methods. Two other general MBR changes:
Contributes to #44806
|
CoffeeFlux
approved these changes
Apr 14, 2021
|
Hello @lambdageek! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A getter/setter change comes in as a modification of the Property table and as several new rows in MethodSemantics. So in pass1 just verify that MethodSemantics only has getter/setter rows and that they point at existing methods.
Two other general MBR changes:
Contributes to #44806