Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Adjustment Rule BaseUtcOffsetDelta #51055

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Apr 10, 2021

Fixes #50256

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@tarekgh tarekgh added this to the 6.0.0 milestone Apr 10, 2021
@tarekgh
Copy link
Member Author

tarekgh commented Apr 10, 2021

@tarekgh
Copy link
Member Author

tarekgh commented Apr 10, 2021

CC @gewarren for the doc part.

@@ -2314,7 +2314,7 @@ public static IEnumerable<object[]> SystemTimeZonesTestData()
for (int i = -14; i <= 12; i++)
{
TimeZoneInfo tz = null;

try
{
string id = $"Etc/GMT{i:+0;-0}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting is going to be subject to the current culture, which could impact the negative sign used. Is that going to be an issue for someone running the tests in, say, Sweden?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to fail. As this is not related to this PR, we can address that in another PR.


In reply to: 611643769 [](ancestors = 611643769)

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some /// suggestions only.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@mattjohnsonpint
Copy link
Contributor

LGTM

@tarekgh tarekgh merged commit ef2e454 into dotnet:main Apr 13, 2021
@tarekgh tarekgh deleted the ExposeAdjustmentRulUtcOffsetDelta branch April 13, 2021 18:17
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BaseUtcOffset to TimeZoneInfo.AdjustmentRule.
6 participants