-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0-preview4] Update dependencies from dotnet/icu #51501
[release/6.0-preview4] Update dependencies from dotnet/icu #51501
Conversation
Microsoft.NETCore.Runtime.ICU.Transport From Version 6.0.0-preview.4.21212.2 -> To Version 6.0.0-preview.4.21216.1
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@jeffschwMSFT I've seen these failures on a few PRs. Any ideas? |
@agocke can you take a look, I see some apphost related failures on this PR. |
Looking |
@mateoatr Can you take a look? Looks like the symbolic link tests again. Can we just remove the deletion? Since the symbolic link is created in a test directory, shouldn't it be cleaned up after the test is done anyway? |
@mateoatr Does that need to be ported to this p4 branch? |
Ugh guess symlinks can't be reliably deleted like other files. Probably need to keep the deletion then but maybe use another pinvoke to do it. Maybe call 'unlink' or 'rm' directly? |
@mateoatr I tried |
…37286b-2444-4604-8ce3-40c2b9b1a303
@mmitche This is ready, I think. |
This pull request updates the following dependencies
From https://github.com/dotnet/icu