[release/6.0-preview4][wasm] Fix Blazor AOT builds inside Visual Studio #52078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In case of `WasmAppBuilder.dll`, we were packaging only the task assembly, and `System.Reflection.MetadataLoadContext` for net472, same as net6.0 . - But for net472, VS fails with errors like: ``` C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.4.21222.10\Sdk\WasmApp.targets(424,4): Error MSB4018: The "PInvokeTableGenerator" task failed unexpectedly. System.IO.FileNotFoundException: Could not load file or assembly 'System.Reflection.Metadata, Version=1.4.5.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. File name: 'System.Reflection.Metadata, Version=1.4.5.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' at System.Reflection.MetadataLoadContext.LoadFromStreamCore(Stream peStream) at System.Reflection.MetadataLoadContext.LoadFromAssemblyPath(String assemblyPath) at System.Reflection.PathAssemblyResolver.Resolve(MetadataLoadContext context, AssemblyName assemblyName) at System.Reflection.MetadataLoadContext.TryFindAssemblyByCallingResolveHandler(RoAssemblyName refName) at System.Reflection.MetadataLoadContext.ResolveToAssemblyOrExceptionAssembly(RoAssemblyName refName) at System.Reflection.MetadataLoadContext.TryResolveAssembly(RoAssemblyName refName, Exception& e) at System.Reflection.MetadataLoadContext.TryGetCoreAssembly(String coreAssemblyName, Exception& e) at System.Reflection.TypeLoading.CoreTypes..ctor(MetadataLoadContext loader, String coreAssemblyName) at System.Reflection.MetadataLoadContext..ctor(MetadataAssemblyResolver resolver, String coreAssemblyName) at PInvokeTableGenerator.GenPInvokeTable(String[] pinvokeModules, String[] assemblies) in /Users/radical/dev/r2/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs:line 42 at PInvokeTableGenerator.Execute() in /Users/radical/dev/r2/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs:line 28 at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() ``` - So, bundle all the dependent assemblies from the publish folder
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
marek-safar
reviewed
Apr 30, 2021
marek-safar
reviewed
Apr 30, 2021
pranavkm
approved these changes
Apr 30, 2021
lewing
changed the title
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsDescriptionFix Blazor AOT builds inside Visual Studio by multi-targeting the build tasks. Customer ImpactWithout these fixes the build fails when run inside Visual Studio causing that experience to be worse than other build methods (command line and VS Code) RegressionNo, these tasks are new in this release TestingManual Testing against the 6.0.100-preview.4.21229.17 sdk and VS Version 16.10.0 Preview 2.1 RiskVery Low. The changes only impact the AOT workload
|
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Apr 30, 2021
dsplaisted
approved these changes
Apr 30, 2021
Comment on lines
+27
to
+31
| <!-- needed for publishing with multi-targeting. We are publishing essentially to get the SR.MetadataLoadContext.dll :/ --> | ||
| <ItemGroup> | ||
| <_PublishFramework Include="$(TargetFrameworks)" /> | ||
| </ItemGroup> | ||
| <MSBuild Projects="$(MSBuildProjectFile)" Targets="Publish" Properties="TargetFramework=%(_PublishFramework.Identity)" /> |
There was a problem hiding this comment.
This looks a bit scary. Aren't the dependencies that need to be packaged included in the build output folder?
There was a problem hiding this comment.
In case of net472, yes, but not for net6.0 :|
There was a problem hiding this comment.
The existing code uses Publish target to get the assembly.
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
|
Validated a local build of 2926086 packages successfully |
lewing
added a commit
that referenced
this pull request
May 1, 2021
* Port additional fixes in #52078 main * Update src/tasks/AotCompilerTask/MonoAOTCompiler.csproj Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com> * Update src/tasks/WasmAppBuilder/WasmAppBuilder.csproj Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com> * Update src/tasks/WasmAppBuilder/WasmAppBuilder.csproj Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com> * Apply suggestions from code review Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com> * Use a property for net472 * Use consistent separator character Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com> Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
lewing
added
Servicing-approved
|
Approved in email. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Blazor AOT builds inside Visual Studio by multi-targeting the build tasks.
Customer Impact
Without these fixes the build fails when run inside Visual Studio causing that experience to be worse than other build methods (command line and VS Code)
Regression
No, these tasks are new in this release
Testing
Manual Testing against the 6.0.100-preview.4.21229.17 sdk and VS Version 16.10.0 Preview 2.1
Risk
Very Low. The changes only impact the AOT workload