[tests] Fix integer rounding error in GetTestFileName #52266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @carlossanlop |
danmoseley
approved these changes
May 5, 2021
| @@ -102,7 +102,9 @@ protected string GetTestFileName(int? index = null, [CallerMemberName] string me | |||
| if (excessLength < memberName.Length + "...".Length) | |||
| { | |||
| // Take a chunk out of the middle as perhaps it's the least interesting part of the name | |||
| memberName = memberName.Substring(0, memberName.Length / 2 - excessLength / 2) + "..." + memberName.Substring(memberName.Length / 2 + excessLength / 2); | |||
| int halfMemberNameLength = (int)Math.Floor((double)memberName.Length / 2); | |||
| int halfExcessLength = (int)Math.Floor((double)excessLength / 2); | |||
There was a problem hiding this comment.
This should probably be Ceil not Floor, and then we don't need the +1 on the math.
src/libraries/Common/tests/TestUtilities/System/IO/FileCleanupTestBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/IO/FileCleanupTestBase.cs
Outdated
Show resolved
Hide resolved
|
Hello @danmoseley! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52257
There seemed to be an integer rounding error when getting a portion of the test file name. Using the suggestion #52257 (comment) led to the tests running to completion with no crashes or hangs.