[release/6.0-preview4] [metadata-update] Make a copy of the DIL when applying updates #52352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Otherwise we may point into memory that is cleaned up by the GC
github-actions
bot
requested review from
CoffeeFlux,
lambdageek,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsBackport of #52344 to release/6.0-preview4 /cc @lambdageek Customer ImpactTestingRisk
|
|
/cc @marek-safar |
|
This is quite late for the final build. We'll get it in only if we respin build for other change. |
leecow
added
Servicing-rejected
and removed
Servicing-consider
|
Closing now that we branched for preview5. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #52344 to release/6.0-preview4
/cc @lambdageek
Customer Impact
Customers trying out hot reload with Blazor WebAssembly, or .NET 6 Android will avoid unexpected crashes in applications that allocate a lot of memory.
Testing
Manual testing in an app that attempted to intentionally corrupt the hot reload update.
Risk
Minimal, hot reload is an opt-in preview feature.