Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable iOS tests #52385

Merged
merged 4 commits into from
May 6, 2021
Merged

Re-enable iOS tests #52385

merged 4 commits into from
May 6, 2021

Conversation

filipnavara
Copy link
Member

Fixes #51389
Fixes #38031
Fixes #51334
Fixes #51333
Fixes #51336
Fixes #51378
Fixes #51374
Fixes #51385
Fixes #51387
Fixes #51412
Fixes #51383

@ghost
Copy link

ghost commented May 6, 2021

Tagging subscribers to this area: @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #51389
Fixes #38031
Fixes #51334
Fixes #51333
Fixes #51336
Fixes #51378
Fixes #51374
Fixes #51385
Fixes #51387
Fixes #51412
Fixes #51383

Author: filipnavara
Assignees: -
Labels:

area-System.Xml

Milestone: -

@akoeplinger
Copy link
Member

Looks like the tvOS simulator build fails due to disk space, I know @steveisok was talking about that as well (we'll need to clean more stuff after each test build).

iOS is passing which is great news :)

@mdh1418
Copy link
Member

mdh1418 commented May 6, 2021

Related: #51491 is in progress to update the library skips and activeissue the different test suites and test facts. f61bd44 Helps with saving space on disk, but I believe there are more things to clean up

@filipnavara
Copy link
Member Author

I knew there was a PR! :-) Feel free to fold this into it. Most of the tests listed here were unblocked by the AppleAppBuilder fix, few by the recent System.Security.Cryptography.Algorithms work.

@akoeplinger
Copy link
Member

I think we should fold f61bd44 into this PR and get it in, since we know it works on iOS already. We can update the other PR after that :)

@akoeplinger
Copy link
Member

Microsoft.Extensions.Configuration.EnvironmentVariables.Tests timed out on tvOSSimulator, but that test wasn't touched in this PR so is unrelated :)

@akoeplinger akoeplinger merged commit 01619ed into dotnet:main May 6, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.