Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Socket APM infrastructure code that's no longer needed #52711

Merged
merged 1 commit into from
May 14, 2021

Conversation

geoffkizer
Copy link
Contributor

Now that we have converted all Socket APM methods to wrap Task APIs, we no longer need the APM infrastructure code.

See #43845 (comment)

Fixes #1383

@antonfirsov

@ghost
Copy link

ghost commented May 13, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Now that we have converted all Socket APM methods to wrap Task APIs, we no longer need the APM infrastructure code.

See #43845 (comment)

Fixes #1383

@antonfirsov

Author: geoffkizer
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffkizer geoffkizer merged commit 10a11fe into dotnet:main May 14, 2021
@geoffkizer geoffkizer deleted the removesocketapm branch May 14, 2021 18:18
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why System.Net.Sockets has dependency to System.Security.Principal.Windows?
3 participants