HTTP2: Ensure we flush when a window limit is hit #52797
Merged
+172
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #52451 When writing a request body, we need to ensure we flush if we hit a window limit (connection or stream) because we don't know when we will be able to write further data, since it depends on receiving a window update from the peer. Also, minor related test cleanup.
|
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dotnet/ncl can I get a review? |
antonfirsov
reviewed
May 21, 2021
Comment on lines
+1468
to
+1472
| bool flush = false; | ||
| if (finalFlush && remaining.Length == 0) | ||
| { | ||
| flush = true; | ||
| } |
There was a problem hiding this comment.
Nit:
Suggested change
| bool flush = false; | |
| if (finalFlush && remaining.Length == 0) | |
| { | |
| flush = true; | |
| } | |
| bool flush = finalFlush && remaining.Length; |
stephentoub
reviewed
May 25, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52451
When writing a request body, we need to ensure we flush if we hit a window limit (connection or stream) because we don't know when we will be able to write further data, since it depends on receiving a window update from the peer.
Also, minor related test cleanup.