Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate APIs throwing PNSE on MacCatalyst #52835

Conversation

MaximLipnin
Copy link
Contributor

This is another iteration on work for annotating APIs unsupported on iOS/tvOS - in part of MacCatalyst and it's mostly going to add [UnsupportedOSPlatform("maccatalyst")] to the classes/methods/etc already annotated for iOS/tvOS.

Part of #47910

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 17, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

This is another iteration on work for annotating APIs unsupported on iOS/tvOS - in part of MacCatalyst and it's mostly going to add [UnsupportedOSPlatform("maccatalyst")] to the classes/methods/etc already annotated for iOS/tvOS.

Part of #47910

Author: MaximLipnin
Assignees: -
Labels:

area-System.Console, new-api-needs-documentation

Milestone: -

@marek-safar
Copy link
Contributor

Is it needed if MacCatalyst derives from xamarin.ios

@MaximLipnin
Copy link
Contributor Author

Is it needed if MacCatalyst derives from xamarin.ios

As far as I can see, the respective GH issue was updated to consider MacCatalyst as well, so perhaps there are some nuances.

@MaximLipnin MaximLipnin force-pushed the mark_unsupported_apis_on_maccatalyst branch from 90927d8 to cb053d3 Compare May 17, 2021 11:35
@MaximLipnin
Copy link
Contributor Author

As discussed offline, iOS annotations should be enough to cover MacCatalyst cases, but it needs some validation

@MaximLipnin MaximLipnin deleted the mark_unsupported_apis_on_maccatalyst branch May 17, 2021 13:18
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants