Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop reading TargetFramework prop in props files #52897

Merged
merged 12 commits into from
May 19, 2021
Merged

Stop reading TargetFramework prop in props files #52897

merged 12 commits into from
May 19, 2021

Commits on May 18, 2021

  1. Stop reading TargetFramework prop in props files 

    The TargetFramework property isn't expected to be set in props files
before a project's body is evaluated.

Don't let BuildTargetFramework property fallback to TargetFramework as
BTF's sole intent is to convey the TargetFramework to filter to and not
the current selected TargetFramework. Reduce usage of BTF so that it is
only used in places where code is actually conditioned on filtering.
    @ViktorHofer
    ViktorHofer committed May 18, 2021
    Configuration menu
    Copy the full SHA
    66b94c9 View commit details
    Browse the repository at this point in the history

  2. Allow traversal project filtering anywhere in the tree

    @ViktorHofer
    ViktorHofer committed May 18, 2021
    Configuration menu
    Copy the full SHA
    b2c0c1a View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary global property passed through

    @ViktorHofer
    ViktorHofer committed May 18, 2021
    Configuration menu
    Copy the full SHA
    fbebf83 View commit details
    Browse the repository at this point in the history

  4. Fix illinking

    @ViktorHofer
    ViktorHofer committed May 18, 2021
    Configuration menu
    Copy the full SHA
    95191e8 View commit details
    Browse the repository at this point in the history

  5. React to prop moves

    @ViktorHofer
    ViktorHofer committed May 18, 2021
    Configuration menu
    Copy the full SHA
    d7c3e50 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into StopReadTFMInProps

    @ViktorHofer
    ViktorHofer authored May 18, 2021
    Configuration menu
    Copy the full SHA
    b179a9e View commit details
    Browse the repository at this point in the history

  7. Update build-native.proj

    @ViktorHofer
    ViktorHofer authored May 18, 2021
    Configuration menu
    Copy the full SHA
    fcdbb01 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into StopReadTFMInProps

    @ViktorHofer
    ViktorHofer authored May 18, 2021
    Configuration menu
    Copy the full SHA
    7727d9b View commit details
    Browse the repository at this point in the history

  9. Update build-native.proj

    @ViktorHofer
    ViktorHofer authored May 18, 2021
    Configuration menu
    Copy the full SHA
    4aadc81 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into StopReadTFMInProps

    @ViktorHofer
    ViktorHofer authored May 18, 2021
    Configuration menu
    Copy the full SHA
    f341c8f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Update build-native.proj

    @ViktorHofer
    ViktorHofer authored May 19, 2021
    Configuration menu
    Copy the full SHA
    d0138ed View commit details
    Browse the repository at this point in the history

  2. Remove BuildingNetCoreAppVertical prop

    @ViktorHofer
    ViktorHofer committed May 19, 2021
    Configuration menu
    Copy the full SHA
    db68e31 View commit details
    Browse the repository at this point in the history