Quote property value #52917
Merged
Quote property value #52917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ViktorHofer
approved these changes
May 18, 2021
|
Merging to unblock failing CI legs. |
akoeplinger
approved these changes
May 18, 2021
janvorli
added a commit
to janvorli/runtime
that referenced
this pull request
May 19, 2021
Port of dotnet#52799 and dotnet#52917 During the repo consolidation, we missed passing OfficialBuildId argument to common script from all subsets, which resulted in default version emitted in the binaries produced by Libs subset in the official builds.
Anipik
pushed a commit
that referenced
this pull request
Jun 3, 2021
* [Release/5.0] - Fix versions for Libs native artifacts Port of #52799 and #52917 During the repo consolidation, we missed passing OfficialBuildId argument to common script from all subsets, which resulted in default version emitted in the binaries produced by Libs subset in the official builds. * Fix empty build version case
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ViktorHofer, @akoeplinger sorry missed checking all the legs logs 😄