GT_COPY source should be marked as consume during resolution #53041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@dotnet/jit-contrib |
|
I will post asmdiff summary (if there is one) later today. |
|
|
|
I tried to repro the failures on COMPlus_TieredCompilation=0
COMPlus_JitStressRegs=2
COMPlus_DbgMiniDumpName=./coredump.1.dmp
COMPlus_DbgEnableMiniDump=1
Discovering: System.CodeDom.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.CodeDom.Tests (found 1423 of 1424 test cases)
Starting: System.CodeDom.Tests (parallel test collections = on, max threads = 46)
Finished: System.CodeDom.Tests
=== TEST EXECUTION SUMMARY ===
System.CodeDom.Tests Total: 5974, Errors: 0, Failed: 0, Skipped: 0, Time: 19.535s
System.CodeDom.Tests
----- end Fri May 21 10:02:56 PDT 2021 ----- exit code 0 ----------------------------------------------------------
COMPlus_TieredCompilation=0
COMPlus_JitStressRegs=0x80
COMPlus_DbgMiniDumpName=./coredump.1.dmp
COMPlus_DbgEnableMiniDump=1
Discovering: Common.Tests (method display = ClassAndMethod, method display options = None)
Discovered: Common.Tests (found 215 of 226 test cases)
Starting: Common.Tests (parallel test collections = on, max threads = 46)
Finished: Common.Tests
=== TEST EXECUTION SUMMARY ===
Common.Tests Total: 1893, Errors: 0, Failed: 0, Skipped: 0, Time: 16.424s
Common.Tests
----- end Fri May 21 10:27:26 PDT 2021 ----- exit code 0 ----------------------------------------------------------
exit code 0 means Exited SuccessfullyI have triggered another run, just to be sure. |
|
The failures are related to #53042 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing the resolution for switch tables, also take into account the source of
SWITCH_TABLEoperand and do not use that register of the source for resolution. Below is the failure that this PR fixes. On left-side, we load the jump table's index inr0but before using it inldr pc, overwrite it with different variablelrbefore we try to reload it inmov r7, r0.The fix is similar to the one done for Arm64 in #48833.
Fixes: #52945
While debugging, I also updated the natvis for
LinearScanso it can display the inVarMap for each block along with register allocated to it. Sample screenshot: