Fix formatting of CircularDependencyException error message #53140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue Detailsto work with trimmed resources
|
to work with trimmed resources
eerhardt
approved these changes
May 23, 2021
stephentoub
reviewed
May 24, 2021
| @@ -39,7 +39,7 @@ public void Add(Type serviceType, Type implementationType = null) | |||
| private string CreateCircularDependencyExceptionMessage(Type type) | |||
| { | |||
| var messageBuilder = new StringBuilder(); | |||
| messageBuilder.AppendFormat(SR.CircularDependencyException, TypeNameHelper.GetTypeDisplayName(type)); | |||
| messageBuilder.Append(SR.Format(SR.CircularDependencyException, TypeNameHelper.GetTypeDisplayName(type))); | |||
| messageBuilder.AppendLine(); | |||
There was a problem hiding this comment.
Shouldn't this instead have been:
messageBuilder.AppendLine(SR.Format(SR.CircularDependencyException, TypeNameHelper.GetTypeDisplayName(type)));? I expect it was only two separate calls previously because there isn't an AppendFormatLine method.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to work with trimmed resources