Enable recently added Microsoft.CodeAnalysis.NetAnalyzers rules #53158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
added
the
NO-MERGE
stephentoub
force-pushed
the
enablenewrules
branch
2 times, most recently
from
ed5c7f5 to
6778073
Compare
stephentoub
force-pushed
the
enablenewrules
branch
2 times, most recently
from
77c814b to
de9124c
Compare
stephentoub
removed
the
NO-MERGE
stephentoub
force-pushed
the
enablenewrules
branch
from
de9124c to
f7c472f
Compare
stephentoub
commented
May 26, 2021
| @@ -454,21 +454,14 @@ public override long Position | |||
| set => throw new NotSupportedException(); | |||
| } | |||
|
|
|||
| public override async Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken) | |||
| public override Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
@kjpou1, would you mind reviewing the changes to this file?
There was a problem hiding this comment.
/cc @pavelsavara @lewing
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.