Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse DOTNET_PROCESSOR_COUNT with a 10 radix not 16 #53208

Merged
merged 2 commits into from
May 25, 2021
Merged

Parse DOTNET_PROCESSOR_COUNT with a 10 radix not 16 #53208

merged 2 commits into from
May 25, 2021

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 6.0.0 milestone May 25, 2021
stephentoub
stephentoub approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@AntonLapounov
Copy link
Member

Could you please fix this line as well?

runtime/src/libraries/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs

Line 33 in 53735f7

int value = (int)wcstoul(ptr, &endptr, 16);

@AaronRobinsonMSFT
Copy link
Member Author

@AntonLapounov Yep. I was just validating locally and noticed that. Thanks for calling it out too.

AntonLapounov
AntonLapounov approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@AntonLapounov AntonLapounov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@richlander richlander mentioned this pull request May 25, 2021
Closed
@AaronRobinsonMSFT
Copy link
Member Author

Product builds/test all pass.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit cc8d9b3 into dotnet:main May 25, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime53150 branch May 25, 2021 05:42
jkotas added a commit to jkotas/runtimelab that referenced this pull request Jun 2, 2021
@jkotas
Parse DOTNET_PROCESSOR_COUNT with radix 10
f40ae19 
Port dotnet/runtime#53208
@jkotas jkotas mentioned this pull request Jun 2, 2021
Merged
MichalStrehovsky pushed a commit to dotnet/runtimelab that referenced this pull request Jun 3, 2021
@jkotas
Parse DOTNET_PROCESSOR_COUNT with radix 10 (#1198)
473bc74 
Port dotnet/runtime#53208
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AntonLapounov AntonLapounov AntonLapounov approved these changes

@stephentoub stephentoub stephentoub approved these changes

@richlander richlander richlander approved these changes

Assignees
No one assigned
Labels
area-VM-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

DOTNET_PROCESSOR_COUNT is a hex value -- should be decimal
4 participants
@AaronRobinsonMSFT @AntonLapounov @richlander @stephentoub