Fix #53181. AssemblyLoadContext incorrectly validates name of dynamiс assembly when returned from Load #53219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @agocke, @CoffeeFlux, @VSadov |
vitek-karas
approved these changes
May 25, 2021
vitek-karas
reviewed
May 25, 2021
| assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(assemblyName, AssemblyBuilderAccess.RunAndCollect); | ||
| } | ||
|
|
||
| AssemblyLoadContext? context = AssemblyLoadContext.GetLoadContext(assemblyBuilder); |
There was a problem hiding this comment.
Actually - can you also validate that the assembly is in the ALC.Assemblies collection?
…ynamic assembly when returned from Load
Ap0k
force-pushed
the
bugfix/GetLoadContextForDynamicAssemblies
branch
from
a8bf6d5 to
f9056b8
Compare
|
The test failure in CI is #48851. |
|
@Ap0k thanks a lot for the fix! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #53181