Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable diagnostics support as default in Mono Android sample app. #53716

Conversation

lateralusX
Copy link
Member

No description provided.

@lateralusX lateralusX changed the title Disable diagnostics support as default in Android sample app. Disable diagnostics support as default in Mono Android sample app. Jun 4, 2021
@marek-safar
Copy link
Contributor

@steveisok can we stop messing up with the sample and do the work property as independent units that we can regularly validate ?

@lateralusX
Copy link
Member Author

The work unit was adding ability to run diagnostics with the sample apps, this issue was a regression from that work, but it actually exposed another issue with our Android release shared library builds not being stripped, dramatically increase the size of sample app when using dynamic linked mono runtime (as used by workloads like XA). Maybe we should have a test running on PR's monitor size of sample apps?

@lateralusX
Copy link
Member Author

Size increase is mainly caused by this, #53722, will temporary remove dynamic linking in sample app on Android until we strip shared libraries as part of runtime build.

@lateralusX
Copy link
Member Author

Switching back to static linking will take APK size of sample app on Android back to 2.6 MB.

@lateralusX lateralusX force-pushed the lateralusX/remove-runtime-components-in-sample branch from f884688 to 8f3656c Compare June 4, 2021 14:44
@lateralusX
Copy link
Member Author

lateralusX commented Jun 4, 2021

Keeping dynamic linking on Android since the should be the default, size will be adjusted once #53240 gets merged.

@lateralusX lateralusX merged commit a9d2f03 into dotnet:main Jun 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants