Add NetCoreAppCurrent config to where it's missing #54215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is addressing the following scenarios in order: - When there is a netcoreapp3.1 or net5.0 asset available in the lib, also add a NetCoreAppCurrent configuration to avoid PackageReferences to libraries that are inbox in net6.0 but not in previous .NetCoreApp versions. Examples are M.Win32.Registry which will be inbox soon. - When there's a NetCoreAppCurrent config in the lib but not in the ref, add it there as well to always resolve the ref of the current version. - When there are NetCoreAppCurrent rid specific configuration in the lib not a non-rid configuration, add one so that P2Ps from rid-less NetCoreAppCurrent configs in other projects, pick the NetCoreAppCurrent config from the lib and the ref.
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsThis is addressing the following scenarios in order:
Contributes to #54012
|
akoeplinger
reviewed
Jun 15, 2021
...braries/Microsoft.Extensions.Logging.Console/ref/Microsoft.Extensions.Logging.Console.csproj
Show resolved
Hide resolved
akoeplinger
reviewed
Jun 15, 2021
src/libraries/Microsoft.Extensions.Primitives/ref/Microsoft.Extensions.Primitives.csproj
Outdated
Show resolved
Hide resolved
akoeplinger
requested changes
Jun 15, 2021
akoeplinger
approved these changes
Jun 15, 2021
|
CI is nearly finished. Merging to get one more change which depends on this in before we snap for P6. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing the following scenarios in order:
also add a NetCoreAppCurrent configuration to avoid PackageReferences
to libraries that are inbox in net6.0 but not in previous .NetCoreApp
versions. Examples are M.Win32.Registry which will be inbox soon.
add it there as well to always resolve the ref of the current version.
not a non-rid configuration, add one so that P2Ps from rid-less
NetCoreAppCurrent configs in other projects, pick the
NetCoreAppCurrent config from the lib and the ref.
Contributes to #54012