Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview6] [FileStream] handle UNC and device paths #54595

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 23, 2021

Backport of #54483 to release/6.0-preview6

/cc @adamsitnik

Customer Impact

FileStream can not open files located on network shares (UNC paths starting with // or \\) and Windows devices (paths starting with \\.\). This is a regression from previous release that impacted many customers (#54337, #54474, #54475) including the WinForms Team (cc @Lydia-Shi).

Testing

I've verified locally that the UNC and device paths work fine now. I've also added tests to ensure that this bug is never coming back #54545.

Risk

The risk is low as we have basically switched back to higher level syscall (what we were doing for .NET 5) that does not require us to handle the DOS to NT paths mapping on our own (from CreateFileW to NtCreateFile), which was the source of the problems.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@adamsitnik
Copy link
Member

cc @safern

@adamsitnik adamsitnik requested a review from stephentoub June 23, 2021 07:31
@adamsitnik adamsitnik added this to the 6.0.0 milestone Jun 23, 2021
@ghost
Copy link

ghost commented Jun 23, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #54483 to release/6.0-preview6

/cc @adamsitnik

Customer Impact

FileStream can not open files located on network shares (UNC paths starting with // or \\) and Windows devices (paths starting with \\.\). This is a regression from previous release that impacted many customers (#54337, #54474, #54475) including the WinForms Team (cc @Lydia-Shi).

Testing

I've verified locally that the UNC and device paths work fine now. I've also added tests to ensure that this bug is never coming back #54545.

Risk

The risk is low as we have basically switched back to higher level syscall (what we were doing for .NET 5) that does not require us to handle the DOS to NT paths mapping on our own (from CreateFileW to NtCreateFile), which was the source of the problems.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.IO

Milestone: 6.0.0

@danmoseley danmoseley added the Servicing-consider Issue for next servicing release review label Jun 25, 2021
@danmoseley
Copy link
Member

This got missed as we didn't label it for tactics.
@stephentoub could you sign off maybe? This seems fairly critical to port.

@danmoseley
Copy link
Member

I'm satisfied that the test failures are unrelated.

@BruceForstall there are several JIT jobs that failed here (crash?) leaving no log. Is the missing log issue something we know about? https://dev.azure.com/dnceng/public/_build/results?buildId=1201218&view=ms.vss-test-web.build-test-results-tab&runId=35979858&paneView=debug&resultId=102659

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches original change.

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 25, 2021
@ViktorHofer ViktorHofer merged commit 1ddcf4c into release/6.0-preview6 Jun 25, 2021
@ViktorHofer ViktorHofer deleted the backport/pr-54483-to-release/6.0-preview6 branch June 25, 2021 16:26
@BruceForstall
Copy link
Member

@danmoseley Yes, that looks like the same windows arm64 issue we've seen lately. A Helix rollout to fix that should have happened this morning, I believe.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants