-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve necessary type and method #54932
Conversation
Tagging subscribers to this area: @eiriktsarpalis, @layomia |
cc @eerhardt |
Could you add the reasoning for these changes, like what depends on it, and how/what fails? |
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr |
....Runtime.InteropServices/tests/System/Runtime/InteropServices/IDispatchImplAttributeTests.cs
Show resolved
Hide resolved
Is Refers to: src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/IDispatchImplAttributeTests.cs:11 in e67171c. [](commit_id = e67171c, deletion_comment = False) |
Might be worth inlining |
Failures of |
@eerhardt and @MichalStrehovsky Are the changes looks okay with you? |
All tests have passed actually. Ready to be merged. |
@fanyang-mono, this test is still disabled against one of the issues this closes: runtime/src/libraries/System.Net.Http/tests/UnitTests/Headers/HttpHeadersTest.cs Line 1541 in a291fab
|
This is reported to have been fixed by #54932.
This is reported to have been fixed by #54932.
Oops, I didn't notice that there were more than one test methods associated with that issue. Will Open another PR to enable it. Thanks for your reminder. |
Already did :-) |
Thank you :) |
Fixes #50721
For test
System.Text.Json.Serialization.Tests.CollectionTests.WriteHashSetTOfHashSetT
,the line of code which triggered System.NullReferenceException was https://github.com/xunit/assert.xunit/blob/3e9f13f2fae7ff8f379da0f19f72d56aea2dae46/Sdk/AssertEqualityComparer.cs#L249
Thus,
CompareTypedSets
was the missing method. It is a method of typeXunit.Sdk.AssertEqualityComparer
, which belongs to assemblyxunit.assert.dll
Fixes #50717
Rewrite the way of getting the type
System.Runtime.InteropServices.IDispatchImplAttribute
.Fixes #53647
Fix for #50721 also fixed this.
Fixes #51911
Simply enable the tests. Not reproducible anymore.