[release/6.0-preview7] Make System.Drawing.Common throw on Unix unless a config switch is set #56114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Immo Landwerth <immo@landwerth.net>
|
Tagging subscribers to this area: @safern, @tarekgh |
ericstj
approved these changes
Jul 22, 2021
jamshedd
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #55962 to release/6.0-preview7
/cc @safern
Customer Impact
Customers will now get a warning when targeting non-Windows and using the System.Drawing.Common package. Also at runtime they will be forced to set a runtime config switch (
System.Drawing.EnableUnixSupport) or they will get aPlatformNotSupportedException.Motivation behind this new behavior described in: dotnet/designs#234
Breaking change notice is: dotnet/docs#25257
Testing
Manual testing for build changes and also added tests for runtime behavior.
Risk
Low, changes are simple and tests back those changes.